-
Notifications
You must be signed in to change notification settings - Fork 2.9k
[ADD] estate : add real estate module #1128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 19.0
Are you sure you want to change the base?
Conversation
artn-odoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job so far !
Just some small styling nitpicks, otherwise it's all good.
We try to always put a new line at the end of a file, this can be done automatically when you save your file in vscode if the Insert Final Newline option is activated.
csan-odoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Just a few minor nitpicks
Add SQL constraints to ensure prices are positive and names are unique. Implement a Python constraint to prevent selling prices below 90% of the expected price.
Implement several UI improvements to enhance user experience and data visibility: - Add state-based decorations (color/bold) to the property and offer list views. - Add inline buttons to the offer list for quick 'Accept' and 'Refuse' actions. - Implement a stat button on the property type form to display a count of related offers. - Enhance the property form with statusbar, ribbons, and color-coded tags. - Update search views with custom filter domains and default groupings.
Create a new link module 'estate_account' that depends on 'estate' and 'account'.
Implement model inheritance for 'estate.property' to override 'action_sold':
- Automatically create an 'account.move' (Customer Invoice) for the property buyer.
- Add two invoice lines using the Command namespace:
1. Commission: 6% of the property selling price.
2. Administrative fees: Fixed amount of 100.00.
Create a kanban view with name, selling price, expected price, best price and tag ids and group them by type id
csan-odoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect! Just make sure to follow the guidelines for the commit title :)
csan-odoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job! Just a couple of quick changes needed.
Complete Chapter 1 of the Owl training by building a reactive Todo application: - Implement 'Playground' and 'Counter' components using 'useState' for reactivity. - Create a reusable 'Card' component featuring 'slots', 'markup' for HTML, and props validation. - Build a 'TodoList' with 'TodoItem' sub-components using 't-foreach' and dynamic attributes. - Implement Todo logic: adding tasks via 'keyup', toggling completion, and deletion via callback props. - Utilize Owl hooks: 'onMounted' and 'useRef' for DOM access (autofocus), and custom 'useAutofocus' hook.
Move all views of a model to its file, remove empty data array
csan-odoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job! Just few nitpicks :)
|
|
||
| .btn-premium:active { | ||
| transform: scale(0.98); | ||
| } No newline at end of file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We try to always leave an empty line at the end of every file.
If you are using vscode there is an option to automatically do it which is called Insert Final Newline.
| <record id="estate_property_offer_view_tree_stat" model="ir.ui.view"> | ||
| <field name="name">estate.property.offer.list.stat</field> | ||
| <field name="model">estate.property.offer</field> | ||
| <field name="arch" type="xml"> | ||
| <list string="Property Offers" editable="bottom" | ||
| decoration-danger="status == 'refused'" | ||
| decoration-success="status == 'accepted'"> | ||
| <field name="property_id"/> | ||
| <field name="price"/> | ||
| <field name="partner_id"/> | ||
| <field name="validity"/> | ||
| <field name="date_deadline"/> | ||
| </list> | ||
| </field> | ||
| </record> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not needed
| <record id="estate_property_offer_view_tree_stat" model="ir.ui.view"> | |
| <field name="name">estate.property.offer.list.stat</field> | |
| <field name="model">estate.property.offer</field> | |
| <field name="arch" type="xml"> | |
| <list string="Property Offers" editable="bottom" | |
| decoration-danger="status == 'refused'" | |
| decoration-success="status == 'accepted'"> | |
| <field name="property_id"/> | |
| <field name="price"/> | |
| <field name="partner_id"/> | |
| <field name="validity"/> | |
| <field name="date_deadline"/> | |
| </list> | |
| </field> | |
| </record> |

No description provided.