[ADD] Real estate application #1132

waterflow80 · 2026-01-19T15:51:32Z

Created the estate module.
Created the EstateProperty model.

robodoo · 2026-01-19T15:51:35Z

- Created the estate module. - Created the EstateProperty model.

- Remvoed pylint error-ingoring commands. - Added Ruff config file for style check. - Reformated some files.

- Added security configuration for the estate module. - Fixes the warning message about the access rules.

- Added a simple test action to the estate module.

plha-odoo

great work for the overall quality of the code and syntax.
congrats on using the correct convention for the commit titles.
a few small comments :

We try to always leave an empty line at the end of every file.
If you are using vscode there is an option to automatically do it which is called Insert Final Newline.
make sure to add your ruff.toml file in a gitignore file so it's not pushed on your branch

plha-odoo · 2026-01-20T16:12:51Z

estate/models/estate_property.py

+from datetime import date
+
+from dateutil.relativedelta import relativedelta


no need for blank lines between related imports

Suggested change

from datetime import date

from dateutil.relativedelta import relativedelta

from datetime import date

from dateutil.relativedelta import relativedelta

Set up the general user interface for the estate app/module. - Added estate menu - Added action window - Set up the fields properties (required, default, etc..) - Added the `active` reserved field to the view

Adds three more views to the `estate` model: - `list`: allows the display of the records in a tabular form. - `form`: allows the create/edit of the record in a more sturctured way. - `search`: allows the search for records using filters, and grouping the results by some chosen fields. - We also defined a default filter: `Available`, which filters the results by `state = New` or `state = Offer Received`. Also adds some refactoring to align with the coding guidelines (new line, import order, etc..).

Added three more features for the real estate: `type`, `tag`, and `offers`. - A property can have one type, and a type can be assigned to multiple properties. - A property can have multiple tags, and each tag can be assinged to multiple properties. - A property can have multiple offers, and an offer can be assigned to multiple properties. In addition to the `fields.One2many('estate.property.offer')` defined in the `estate.property` model, we had to add `fields.Many2one('estate.property')` in the `estate,property.offer`, because the `One2many` is a virtual relationship.

plha-odoo

good job on applying the correct title convention for the last commits
a few comments:

don't forget to add your ruff.toml file in a gitignore file

plha-odoo · 2026-01-22T12:23:10Z

estate/models/__init__.py

+from . import (
+    estate_property,
+    estate_property_offer,
+    estate_property_tag,
+    estate_property_type,
+)


Suggested change

from . import (

estate_property,

estate_property_offer,

estate_property_tag,

estate_property_type,

)

from . import estate_property

from . import estate_property_offer

from . import estate_property_tag

from . import estate_property_type

Actually, when I run:

ruff check estate/models/__init__.py --fix --config ruff.toml

ruff automatically reformats it that way.

Should I change the ruff.toml file ?

plha-odoo · 2026-01-22T12:24:09Z

estate/models/estate_property.py

+from datetime import date
+
+from dateutil.relativedelta import relativedelta


Suggested change

from datetime import date

from dateutil.relativedelta import relativedelta

from datetime import date

from dateutil.relativedelta import relativedelta

Same as this comment, ruff automatically formats it like that.

Maybe I'm using the wrong ruff.toml file ?

plha-odoo · 2026-01-22T12:24:09Z

estate/models/estate_property.py

+from datetime import date
+
+from dateutil.relativedelta import relativedelta


Suggested change

from datetime import date

from dateutil.relativedelta import relativedelta

from datetime import date

from dateutil.relativedelta import relativedelta

Please see comment.

plha-odoo · 2026-01-22T12:26:26Z

estate/models/estate_property.py

+    # res.users: the users of the system. Users can be 'internal', i.e. they have access to the Odoo backend. Or they can be
+    # 'portal', i.e. they cannot access the backend, only the frontend (e.g. to access their previous orders in eCommerce).


We try to add explication comment only when really needed (because of tricky behaviour for instance)

You're right, I just wanted to add them for reference for later (when I get back the PR in the future).

I removed them.

plha-odoo · 2026-01-22T12:26:33Z

estate/models/estate_property.py

+    # res.users: the users of the system. Users can be 'internal', i.e. they have access to the Odoo backend. Or they can be
+    # 'portal', i.e. they cannot access the backend, only the frontend (e.g. to access their previous orders in eCommerce).
+    sales_person_id = fields.Many2one('res.users', string='Salesman', index=True, default=lambda self: self.env.user)
+    # res.partner: a partner is a physical or legal entity. It can be a company, an individual or even a contact address.


plha-odoo · 2026-01-22T12:27:13Z

estate/models/estate_property_offer.py

+        copy=False,
+    )
+    partner_id = fields.Many2one('res.partner', required=True)
+    # Because a One2many is a virtual relationship, there must be a Many2one field defined in the comodel.


same here

Suggested change

# Because a One2many is a virtual relationship, there must be a Many2one field defined in the comodel.

Adds computed fields such as the `total area`. The `validity` can also be updated automatically when the `total_area` is explicitly set. Adds `onchange` listeners to update the offer form's fields `Garden Area` and `Garden Orientation` automatically when the `Garden` field is set. When the latter field is set, the `Garden Area` is given a default value of 10, and the `Garden Orientation` is set to North.

Adds `accept` and `cancel` buttons to the property form, and links them to the correct python methods (actions). When an offer is accepted, the property's buyer info, as well as the selling price are automatically updated.

Adds constraints on field `expected_price`, tag names, type names, and the minimum offer price accpeted (calculated based on the expected price). Some constraints are defined using plain SQL, and others using the python's `@api.constrains`.

Adds the `title` attribute to the `button` tag. Fixes the error: A button with icon attribute (fa-check) must have title in its tag, parents, descendants or have text.

waterflow80 force-pushed the 19.0-develop-estate-module-hahas branch from ac904f3 to de075ba Compare January 19, 2026 16:10

waterflow80 changed the title ~~[ADD] Setup real estate application~~ [ADD] Real estate application Jan 19, 2026

[ADD] real estate module

ff5d6b3

- Created the estate module. - Created the EstateProperty model.

waterflow80 force-pushed the 19.0-develop-estate-module-hahas branch from de075ba to ff5d6b3 Compare January 19, 2026 16:28

waterflow80 added 3 commits January 20, 2026 14:35

[IMP] Setup ruff & remove pylint

c2f73b8

- Remvoed pylint error-ingoring commands. - Added Ruff config file for style check. - Reformated some files.

[ADD] security configuration for estate

f56cb74

- Added security configuration for the estate module. - Fixes the warning message about the access rules.

[ADD] Add action to estate module

a2089f1

- Added a simple test action to the estate module.

waterflow80 force-pushed the 19.0-develop-estate-module-hahas branch from e3002a3 to a2089f1 Compare January 20, 2026 13:37

waterflow80 mentioned this pull request Jan 20, 2026

hahas - Technical on-boarding #1122

Closed

plha-odoo reviewed Jan 20, 2026

View reviewed changes

[IMP] Added ui views

3f06a7a

Set up the general user interface for the estate app/module. - Added estate menu - Added action window - Set up the fields properties (required, default, etc..) - Added the `active` reserved field to the view

waterflow80 force-pushed the 19.0-develop-estate-module-hahas branch from fdca6dc to 3f06a7a Compare January 20, 2026 16:20

waterflow80 added 2 commits January 21, 2026 14:45

plha-odoo reviewed Jan 22, 2026

View reviewed changes

waterflow80 added 4 commits January 22, 2026 17:21

[CLN] estate: remove ruff.toml and add it to .gitignore

d1f1fad

[LINT] estate: add missing line before class definition

d82e9b7

[LINT] estate: remove unnecessary blank line

6754e8f

waterflow80 force-pushed the 19.0-develop-estate-module-hahas branch from 4b52e5d to 6754e8f Compare January 23, 2026 08:46

waterflow80 added 4 commits January 23, 2026 11:09

[IMP] estate: add actions to the property form

0bda7e7

Adds `accept` and `cancel` buttons to the property form, and links them to the correct python methods (actions). When an offer is accepted, the property's buyer info, as well as the selling price are automatically updated.

[FIX] estate: fix ci/tutorial error

5cb4dde

Adds the `title` attribute to the `button` tag. Fixes the error: A button with icon attribute (fa-check) must have title in its tag, parents, descendants or have text.

[LINT] estate: fix linting errors

3d8ce85

waterflow80 requested a review from plha-odoo January 26, 2026 09:55

		from datetime import date

		from dateutil.relativedelta import relativedelta

		# res.users: the users of the system. Users can be 'internal', i.e. they have access to the Odoo backend. Or they can be
		# 'portal', i.e. they cannot access the backend, only the frontend (e.g. to access their previous orders in eCommerce).

[ADD] Real estate application #1132

Are you sure you want to change the base?

[ADD] Real estate application #1132

Uh oh!

Conversation

waterflow80 commented Jan 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

robodoo commented Jan 19, 2026

Uh oh!

plha-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

plha-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

waterflow80 commented Jan 19, 2026 •

edited

Loading