misleading comment on SPRT calculator page#2374
Open
FauziAkram wants to merge 1 commit intoofficial-stockfish:masterfrom
Open
misleading comment on SPRT calculator page#2374FauziAkram wants to merge 1 commit intoofficial-stockfish:masterfrom
FauziAkram wants to merge 1 commit intoofficial-stockfish:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Isn't this comment wrong? (If I got it wrong, please feel free to close the PR).
The pass/fail probabilities for an SPRT test depend on the drift and variance of the LLR. These properties are directly influenced by the variance of game outcomes, which is heavily dependent on the draw ratio. Therefore, the Logistic model's performance is affected by the draw ratio.
With the new comment, we clarify that the main benefit of the Normalized model is stabilizing the expected test duration, rather than making the test entirely independent of the auxiliary data.
No functional change