fix(access-control): prevent fail-open negated ACL conditions#5714
Draft
leseb wants to merge 1 commit intoogx-ai:mainfrom
Draft
fix(access-control): prevent fail-open negated ACL conditions#5714leseb wants to merge 1 commit intoogx-ai:mainfrom
leseb wants to merge 1 commit intoogx-ai:mainfrom
Conversation
Signed-off-by: Sébastien Han <seb@redhat.com>
Collaborator
Author
|
@r3v5 do you want to take over? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes ACL negation conditions that could fail open in
permit ... unless ...rules when owner or user attribute data is missing.It introduces tri-state condition evaluation (
match,no_match,indeterminate) and updates rule evaluation so indeterminate results never widen access.It also replaces a stray
printwith structured logging and adds targeted unit tests for condition behavior and server access-policy regressions.Test Plan
uv run pytest tests/unit/core/access_control/test_conditions.py tests/unit/server/test_access_control.py -q74 passed, 2 warnings in 0.58s(existing AsyncMock coroutine warnings intests/unit/server/test_access_control.py).