fix(storage): add connection resilience to PostgreSQL kvstore#5734
Open
derekhiggins wants to merge 1 commit intoogx-ai:mainfrom
Open
fix(storage): add connection resilience to PostgreSQL kvstore#5734derekhiggins wants to merge 1 commit intoogx-ai:mainfrom
derekhiggins wants to merge 1 commit intoogx-ai:mainfrom
Conversation
derekhiggins
requested review from
bbrowning,
cdoern,
franciscojavierarceo,
leseb,
mattf and
raghotham
as code owners
derekhiggins
force-pushed
the
fix/postgres-kvstore-resilience
branch
from
2817d47 to
a07b29e
Compare
The PostgreSQL kvstore fails permanently after a database restart because it holds a single connection/cursor with no reconnect logic. Add retry-on-error that catches InterfaceError/OperationalError, reconnects once, and retries the operation. Fixes: ogx-ai#5610 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Derek Higgins <derekh@redhat.com>
derekhiggins
force-pushed
the
fix/postgres-kvstore-resilience
branch
from
a07b29e to
e3d5aea
Compare
franciscojavierarceo
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
InterfaceError/OperationalError, reconnects once, and retries the operation_connect()so it can be reused by_reconnect()Fixes: #5610
Test plan
test_kvstore_recovers_after_postgres_restartverifies:InterfaceError: cursor already closed)