fix(knowledge): recover short exact-name atoms without an ANN index - #2383
Draft
ohdearquant wants to merge 1 commit into
Draft
fix(knowledge): recover short exact-name atoms without an ANN index#2383ohdearquant wants to merge 1 commit into
ohdearquant wants to merge 1 commit into
Conversation
A query where every token falls below the minimum scoreable length (e.g. "AI") never reaches full-text search as anything but the raw phrase, and the trigram tokenizer can't match a phrase that short either. That left such atoms unreachable by knowledge.search unless an embedder and ANN index were configured. When the lexical stage finds nothing and no query token was scoreable, probe the unique (namespace, slug) index with the query normalized through the same slugification the pack's own import path already uses. A hit reports candidate_provenance.lexical: "exact_name"; a read-deadline expiry inside the probe degrades the same way any other lexical timeout does, rather than surfacing as a miss.
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recovers short exact-name atoms when no ANN index is available.
timed_outrather than as a miss.Hit,Miss,TimedOut) so a timeout is never mistaken for absence.Stacked on the score-provenance change; targets that branch until it merges.