Refine mobile app credentials and iOS project configuration by ohmzi · Pull Request #77 · ohmzi/Tday

ohmzi · 2026-05-23T05:59:13Z

No description provided.

… project. This update explicitly configures the development team ID for the primary build targets and performs a non-functional cleanup of the project file by reordering various source and resource references to maintain alphabetical consistency. - **Project Configuration**: - Set `DEVELOPMENT_TEAM` to `JUFACN2FS3` for both Debug and Release configurations. - **Build System Clean-up**: - Alphabetized entries in `PBXBuildFile`, `PBXFileReference`, and `PBXGroup` sections to resolve minor ordering inconsistencies. - Specifically reordered references for `NotificationDeepLinkRouter.swift`, `TodayTasksWidgetSnapshotStoreTests.swift`, `CalendarPagingScrollView.swift`, and other internal source files. Signed-off-by: ohmzi <6551272+ohmzi@users.noreply.github.com>

This update modifies the `DEVELOPMENT_TEAM` identifier within the project's build configurations to ensure proper code signing and provisioning. - **Build Settings**: - Updated the `DEVELOPMENT_TEAM` value from `JUFACN2FS3` to `THT5Z8K3TF` across project configurations. Signed-off-by: ohmzi <6551272+ohmzi@users.noreply.github.com>

…cate used for the app so webcredentials AASA can match the signed bundle identifier.

deepsource-io · 2026-05-23T05:59:28Z

DeepSource Code Review

We reviewed changes in 383ee75...3ba340b on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

PR Report Card

Overall Grade	Security Reliability Complexity Hygiene

Code Review Summary

Analyzer	Updated (UTC)	Details
JavaScript	May 23, 2026 6:00a.m.	Review ↗
Kotlin	May 23, 2026 6:00a.m.	Review ↗
Secrets	May 23, 2026 6:00a.m.	Review ↗

Important

AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.

deepsource-io · 2026-05-23T06:00:45Z

+        } catch (error: CreateCredentialException) {
+            Log.w(
+                LOG_TAG,
+                "Android Password Manager could not save server URL: ${error.type}",
+                error
+            )
+            SystemCredentialSaveResult.FAILED
+        }


This catch block is unreachable.

Unreachable catch blocks should be removed, because they serve no useful purpose and can lead to confusing and potentially incorrect behavior in exception handling.

deepsource-io · 2026-05-23T06:00:45Z

-
 @OptIn(ExperimentalMaterial3Api::class, ExperimentalFoundationApi::class)
 @Composable
 fun CalendarScreen(


`CalendarScreen` has a cyclomatic complexity of 33 with "Very High" risk

Cyclomatic complexity is a software metric that measures the number of
independent paths through a function. A function with high cyclomatic
complexity can be hard to understand and maintain. A higher cyclomatic
complexity indicates that the function has more decision points and is more complex.

deepsource-io · 2026-05-23T06:00:45Z

+    fun `login credential accepts normal password records`() {
+        val credential = SystemCredentialRecords.loginCredential(
+            id = " User@Example.com ",
+            password = "Password!1",


Multiple occurrences of the same string literal within a single file detected. Prefer extracting the string literal into a property or constant.

Avoiding repeated string literals in the same scope is considered good practice in Kotlin. By using shared constants/variables, one improves code maintainability, readability, consistency, and support for localization efforts. Repeated string literals can make code harder to understand, update, and translate. Using shared constants or variables promotes code consistency and potential performance optimizations.

deepsource-io · 2026-05-23T06:00:45Z

+    id("com.android.application") version "9.2.1" apply false
+    id("com.android.library") version "9.2.1" apply false
+    id("org.jetbrains.kotlin.android") version "2.2.10" apply false
    id("org.jetbrains.kotlin.jvm") version "2.1.0" apply false


Multiple occurrences of the same string literal within a single file detected. Prefer extracting the string literal into a property or constant.

Avoiding repeated string literals in the same scope is considered good practice in Kotlin. By using shared constants/variables, one improves code maintainability, readability, consistency, and support for localization efforts. Repeated string literals can make code harder to understand, update, and translate. Using shared constants or variables promotes code consistency and potential performance optimizations.

ohmzi and others added 26 commits May 22, 2026 14:09

Fix mobile realtime refresh parsing

906cf0a

Fix mobile reminder deep links

a3a3c66

Refine Android calendar paging

30a6113

Extract mobile calendar pager helpers

b2075e5

Align mobile contracts and sync fetch

e986563

Remember mobile server URL credentials

f02452e

Fix iOS reinstall server URL cleanup

f1ab0cb

Keep Android server URL out of password manager

97aa54a

Fix iOS server URL password prompt

b4731cb

Restore iOS password prompts

c04a669

Target iOS saved login prompts

936d306

Restore iOS password prompts

ecc6cf5

Restore Android server URL credentials

c2fbbf8

Sequence Android credential prompts

1c4b1e1

Enable automatic iOS signing

e98e28d

Rename mobile app display name

72d399c

Include Sentry dSYM in iOS archives

3186b2d

Settle Android credential handoff

df535fe

Use dynamic Sentry iOS package

e827ca6

Update iOS signing team

d83bb9a

Align the iOS project signing team with the Apple Development certifi…

7b4a732

…cate used for the app so webcredentials AASA can match the signed bundle identifier.

Configure iOS webcredentials server association

9731a8a

Refine iOS onboarding credential prompts

3ba340b

deepsource-io Bot reviewed May 23, 2026

View reviewed changes

ohmzi merged commit 95017cc into master May 23, 2026
3 of 5 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refine mobile app credentials and iOS project configuration#77

Refine mobile app credentials and iOS project configuration#77
ohmzi merged 26 commits into
masterfrom
develop

ohmzi commented May 23, 2026

Uh oh!

deepsource-io Bot commented May 23, 2026 •

edited

Loading

Uh oh!

deepsource-io Bot May 23, 2026

Uh oh!

deepsource-io Bot May 23, 2026

Uh oh!

deepsource-io Bot May 23, 2026

Uh oh!

deepsource-io Bot May 23, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

ohmzi commented May 23, 2026

Uh oh!

deepsource-io Bot commented May 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

DeepSource Code Review

PR Report Card

Code Review Summary

Uh oh!

deepsource-io Bot May 23, 2026

Choose a reason for hiding this comment

This catch block is unreachable.

Uh oh!

deepsource-io Bot May 23, 2026

Choose a reason for hiding this comment

`CalendarScreen` has a cyclomatic complexity of 33 with "Very High" risk

Uh oh!

deepsource-io Bot May 23, 2026

Choose a reason for hiding this comment

Multiple occurrences of the same string literal within a single file detected. Prefer extracting the string literal into a property or constant.

Uh oh!

deepsource-io Bot May 23, 2026

Choose a reason for hiding this comment

Multiple occurrences of the same string literal within a single file detected. Prefer extracting the string literal into a property or constant.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

deepsource-io Bot commented May 23, 2026 •

edited

Loading