fix: rename and fetch_data progress report#12
Conversation
| .unlink(&src.strip_prefix(&base).unwrap()) | ||
| .map_err(|_| CloudErrorKind::InvalidRequest)?; | ||
| } | ||
| (false, true) => Err(CloudErrorKind::NotSupported)?, // TODO |
There was a problem hiding this comment.
What's wrong with the old impl w/ self.create_dir_all and self.create_file?
There was a problem hiding this comment.
No, it's simpler way.
There was a problem hiding this comment.
I agree, a lot of the impl can be greatly simplified and probably replaced with a single call to fs::copy, but this functionality shouldn't be removed from the example.
|
Hi @ok-nick, any problems left? |
|
This fix looks weird but it works well.
|
|
Ah, so when the target isn't in scope and the source is, it will invoke If that's the case, I wonder if it'd be better to replace the |
|
It will not inoke |
|
How is the file removed from the remote then, if not invoked by Also, we should keep the existing functionality for moving a file from outside the sync filter to inside the sync filter rather than keeping it as |
|
I pushed a branch named |
|
I think I can't fix this problem, thanks for your reviews |
2 participants
No description provided.