refactor: update dependencies and examples#17
Merged
Conversation
- Updated windows crate to latest - Update command module to use latest operation parameter structures - Refactor examples to use latest apis and update callback functions - Fix parsing SyncRootId to components
ok-nick
requested changes
Sep 6, 2025
ok-nick
left a comment
ok-nick
left a comment
Owner
There was a problem hiding this comment.
Thank you the contributions! Just a few comments.
- Removed unwanted generic parameter from `Placeholder::create` - Improve `SyncRootId::to_components` - Add test cases to test `SyncRootId::to_components` Co-authored-by: ok-nick nick.libraries@gmail.com
ok-nick
approved these changes
Sep 7, 2025
ok-nick
left a comment
ok-nick
left a comment
Owner
There was a problem hiding this comment.
Thanks again for these changes.
Comment on lines
+141
to
+153
| let mut parts = self.0.splitn(3, |&byte| byte == Self::SEPARATOR); | ||
|
|
||
| // Pattern match on the iterator to safely extract the three parts. | ||
| if let (Some(first), Some(second), Some(third)) = (parts.next(), parts.next(), parts.next()) | ||
| { | ||
| Ok(( | ||
| U16Str::from_slice(first), | ||
| U16Str::from_slice(second), | ||
| U16Str::from_slice(third), | ||
| )) | ||
| } else { | ||
| Err(Foundation::ERROR_INVALID_DATA.into()) | ||
| } |
| } | ||
| } | ||
|
|
||
| #[cfg(test)] |
Owner
There was a problem hiding this comment.
This is great as well, thank you.
ok-nick
added a commit
that referenced
this pull request
Sep 7, 2025
* build: update dependencies * refactor: update dependencies and examples (#17) * refactor: update windows dependency and refactor examples - Updated windows crate to latest - Update command module to use latest operation parameter structures - Refactor examples to use latest apis and update callback functions - Fix parsing SyncRootId to components * refactor: `Placeholder::create` and `SyncRootId::to_components` - Removed unwanted generic parameter from `Placeholder::create` - Improve `SyncRootId::to_components` - Add test cases to test `SyncRootId::to_components` Co-authored-by: ok-nick nick.libraries@gmail.com --------- Co-authored-by: Ajay Kumar M <ajaykumarncas@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the Windows crate and aligns examples with the latest APIs. The cloud-mirror example has been fully tested, while the sftp example now compiles but remains untested.
Changes