Repository navigation
[fix] Re-probe reachability sooner after a failed probe - #17
Merged
Merged
Conversation
An open port answers within seconds, so the first retry no longer waits a minute: 10s, 20s, 30s, then 1, 2 and 5 minutes, then every 5.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #16. The re-probe started at 1 minute and doubled to 15. If the port is open a probe passes within seconds, so that first minute was a minute of red for nothing.
The waits are now an explicit schedule: 10 s, 20 s, 30 s, 1 min, 2 min, 5 min, then every 5 min. A probe is five pings, so the steady state costs nothing worth saving, and a port that is genuinely closed is still not hammered.
intervalMs/maxIntervalMsare replaced by a singlescheduleMsoption.Testing
test/unit/reprobe.test.js: the default sequence including the repeated last wait, and a replaced schedule. 7/7.npm run lintclean,npm testgreen.