Repository navigation
[feat] State reachability and mode together at the top of both pages - #19
Merged
Merged
Conversation
Both headers now carry the same two pills, reachability and mode; the members page fills its from the anonymous snapshot, so it is right before any token is given. The status hero names the mode at the same weight as the verdict. The members page's two warning boxes become ordinary hints inside the invite card.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From testing on a live box: the two pages disagreed about what the top-right pill meant (mode on the members page, reachability on the status page), the mode on the status page was a small pill under a very large verdict, and the members page dressed two pieces of ordinary guidance as yellow warnings.
What changes
status.jsonfor both, so its header is right before a token is entered; withMIRALL_RELAY_ADMIN_UI=falseit falls back to today's behaviour (no reachability pill,Lockeduntil unlocked).Reachable Public relay. The member count stays in its tile; the hero repeats it only for the one case that changes what the relay does,Private relay · no members.hinttext inside the Invite someone card instead ofnote warnboxes. Nothing on that page is toned as a warning now except the error line.access-copy.jsbeside the mode wording, so both pages name both things from one definition.verdict()in the status page keeps the sentences.Testing
reachabilityPill(including asserted-never-shown-as-measured), the two-pill headers, the hero headline in public / private / empty-private, the plain-text notices, and the members script's snapshot fetch having a failure path.note warnon the mode notice.npm run lintclean,npm test416/416.