Repository navigation
[feat] Use the blind-relay mark as the pages' icon - #21
Merged
Merged
Conversation
Replaces the hand-drawn SVG with the armband artwork the StartOS package already ships as its icon, at 64px. Served as icon.png beside each page, with a relative href, so it works behind a proxy prefix and survives MIRALL_RELAY_ADMIN_UI=false on the members page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the favicon from #20, which was a hand-drawn SVG of the wordmark's M, with the real brand artwork: the blindfolded M the StartOS package already ships as its service icon. The browser tab and the StartOS dashboard now show the same mark.
src/operator/icon.png: the artwork at 64 px, RGBA, 6.3 KB./icon.pngand/admin/icon.png, and referenced with a relativehref="icon.png": both pages sit behind platform proxies under prefixes they cannot know, and the members page keeps its own copy soMIRALL_RELAY_ADMIN_UI=falsedoes not take its icon away with the status page's routes./icon.pngjoinsuiPathsautomatically, so the Host guard covers it.Testing
image/png, a real PNG, under 16 KB.image/pngover real HTTP with the bytes intact.icon.pngadded to the list of assets the Docker image must ship.npm run lintclean,npm test418/418.