Skip to content

Feat/Enhance manifest#110

Merged
okdv merged 11 commits intodevelopfrom
feat/semantic-map-urls
Aug 14, 2025
Merged

Feat/Enhance manifest#110
okdv merged 11 commits intodevelopfrom
feat/semantic-map-urls

Conversation

@okdv
Copy link
Copy Markdown
Owner

@okdv okdv commented Aug 14, 2025

Pull Request Checklist:

Please ensure the following points are checked before requesting a review. Asterisk (*) denotes that it is required prior to merge.

  • I have read the CONTRIBUTING.md document. *
  • I have updated the documentation (if applicable).
  • I have added or updated any relevant tests
  • I have run npm run pre-push * (if playwright test failed just notate why below)
  • I merged (or rebased) develop into my branch before pushing *
  • This PR is ready for review and not a draft. *

Description:

added type for shape of manifest
enhanced manifest itself
enhanced navbar, map store and map service to use new data type
created tests for manifest


Related Issues (if any):

closes #105


Type of Change:

Please check the applicable options.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactoring/Code quality improvement
  • Other (please describe below)

How Has This Been Tested?

pre-push
added vitest tests under stores/map.test.ts


Screenshots (if applicable):


Additional Comments:

@okdv okdv added this to the v1.0.0-beta.5 milestone Aug 14, 2025
@okdv okdv self-assigned this Aug 14, 2025
@okdv okdv added the enhancement New feature or request label Aug 14, 2025
@okdv
Copy link
Copy Markdown
Owner Author

okdv commented Aug 14, 2025

not really sure what is causing this to fail... it seems to be hanging on rendering the map build
this works locally, only getting the error in the CI
this test will be undone by later parts of this branch so I guess to removing the test for time sake

@okdv okdv merged commit 3d5be33 into develop Aug 14, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant