Feat/Support selectedFeatures for multiple maps concurrently#116
Merged
Feat/Support selectedFeatures for multiple maps concurrently#116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist:
Please ensure the following points are checked before requesting a review. Asterisk (*) denotes that it is required prior to merge.
npm run pre-push* (if playwright test failed just notate why below)developinto my branch before pushing *Description:
Updated store so that is uses a Record Set of selectedFeatures within a Record Set of maps (interactive layers)
add functions to the stores service to make updating nested Records simple
updated map service to properly find the selected layer and selector again (using new store data)
created a svelte store for storing the current interactive layer, it is a store only no localstorage
Related Issues (if any):
closes #108
Type of Change:
Please check the applicable options.
How Has This Been Tested?
wasnt sure of any tests to add atm, may add some when entire feature is done
pre-push
Screenshots (if applicable):
Additional Comments: