Use types from pudo's 'typecast' library, PEP8 etc#171
Open
davidread wants to merge 36 commits into
Open
Conversation
Probably occurred during rebasing.
This line worked in Python 3.5 because of PEP 461: https://www.python.org/dev/peps/pep-0461/ but not in Python 3.4.
Contributor
|
+1 I'm so keen to finally get a cleanup of messytables. |
chfw
reviewed
Apr 7, 2017
|
Can someone push this fix please? |
Collaborator
Author
4aa3101 to
126630d
Compare
StevenMaude
added a commit
to cantabular/messytables
that referenced
this pull request
Jul 5, 2020
Non-merged PR: okfn#171
StevenMaude
added a commit
to cantabular/messytables
that referenced
this pull request
Jul 5, 2020
Non-merged PR: okfn#171
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@pudo's #155 with fixes from @StevenMaude
Let's see if we can get this merged?