Skip to content

Fix comparison for summary option in list fragment#874

Open
Natureshadow wants to merge 1 commit intookkur:masterfrom
Natureshadow:patch-1
Open

Fix comparison for summary option in list fragment#874
Natureshadow wants to merge 1 commit intookkur:masterfrom
Natureshadow:patch-1

Conversation

@Natureshadow
Copy link
Copy Markdown

For me, the comparison with boolean true did not work for the following frontmatter:

summary = true

The string comparison works.

Fix comparison for `summary` option in `list` fragment
@stp-ip
Copy link
Copy Markdown
Member

stp-ip commented May 10, 2022

This is used throughout the code so shouldn't be an issue.
Will keep this open, but won't merge as this fix is more a temporary and local thing. We can't change this boolean to a string especially as we use booleans throughout the code.
Maybe Hugo changed something to make this break. 🤔

@stp-ip stp-ip added the revisit label May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants