feat: add parallax on hero#877
Open
sergiopena wants to merge 1 commit intookkur:masterfrom
Open
Conversation
Add boolean to set the hero background image as fixed creating a parallax scroll effect.
Member
|
Thank you for the addition already. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add boolean to set the hero background image as fixed to create a parallax scroll effect.
What this PR does / why we need it:
Adds a nice parallax effect to the Hero partial
Which issue this PR fixes
partially fixes #814
Special notes for your reviewer:
I started learning Hugo and this theme seven hours ago, so I literally don't know what I'm doing.
Just saw that it looked super easy to add a bool to fix the image in the background and get the effect 😇
It works on my computer ™️
Release note: