lib/tapi: support reusing existing IP addresses#80
Open
okt-viacheslav wants to merge 1 commit into
Open
Conversation
ol-damirm
approved these changes
Jul 21, 2025
ol-andrewr
approved these changes
Aug 29, 2025
ol-arteman
requested changes
Oct 20, 2025
Comment on lines
+2038
to
+2039
| "/ip%u_address:%jx", | ||
| af == AF_INET ? 4 : 6, 0); |
Collaborator
There was a problem hiding this comment.
Why %jx ? Also 0 would not be converted to intmax_t, since it's a variadic argument, so you may end up getting garbage.
Contributor
Author
There was a problem hiding this comment.
I'm not sure. The rest of the file uses %jx, I'm just following what's already written. Should I use something else?
The missing cast is a good point, I'll add it if we decide to keep %jx
Contributor
Author
There was a problem hiding this comment.
We still need to decide if we want to change %jx to something else
Some configurations do not allow IP reconfiguration on hosts, otherwise they end up unreachable. One example of this is cloud environments. Give tests a way to prevent any IP address changes on the agent interfaces by using IP addresses already configured on agent hosts. Signed-off-by: Viacheslav Galaktionov <viacheslav.galaktionov@oktet.tech> Reviewed-by: Sergey Nikitin <sergey.nikitin@oktet.tech>
okt-viacheslav
force-pushed
the
ip_reuse
branch
from
1d22049 to
73e5710
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some configurations do not allow IP reconfiguration on hosts, otherwise they end up unreachable. One example of this is cloud environments.
Give tests a way to prevent any IP address changes on the agent interfaces by using IP addresses already configured on agent hosts.
Reviewed-by: Sergey Nikitin sergey.nikitin@oktet.tech
Testing done: tested by running test agents on an AWS network