Add optional boolean type#84
Conversation
Similar to the optional uint type, but for boolean variables. Signed-off-by: Artemii Morozov <artemii.morozov@arknetworks.am> Acked-by: Yurij Plotnikov <yurij.plotnikov@arknetworks.am>
These functions and marcos could be used to get optional boolean type from the XML. Signed-off-by: Artemii Morozov <artemii.morozov@arknetworks.am> Acked-by: Yurij Plotnikov <yurij.plotnikov@arknetworks.am>
ol-arteman
left a comment
There was a problem hiding this comment.
We do already have te_bool3 type with three values and a job opt wrapper for it TAPI_JOB_OPT_ENUM_BOOL3. So I'd like to see any rationale why we need another type with basically the same semantics. Or e.g. why we should abandon te_bool3 in favor of te_optional_bool_t
|
Sorry for great delay in anwer(
Which option do you prefer? |
I am definitely for option (3). |
|
Created new PR with (3) |
Add optional boolean type and helpers for it.