Skip to content

Issues with start and end times for all-day events #213

Description

@osteele

In add-edit-page.js#132:

      if (eventData.allDay) {
        eventData.start.startOf('day');
        eventData.end.endOf('day');
      }
  1. eventData.start.startOf('day') should presumably be eventData.start = eventData.start.startOf('day'), ditto for eventData.end.
  2. eventData.end.endOf('day') sets the time to 23:59:59. Presumably what's wanted is actually startOf('day').
  3. These times are start of (and, given (2), end of) day in local time. Presumably this should be in UTC.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions