Minimal RTL support#5
Open
yohanboniface wants to merge 1 commit into
Open
Conversation
Author
|
Piing :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adapts the toolbar alignment behaviour when in RTL mode (for example for Arabic).
It can be set with a new
rtloption (that defaults to false), plus it's automatic ifdir='rtl'is set on thehtmlnode.I've also renamed
diffLeftanddiffToptooffsetXandoffsetYbecause I though that was more conventional naming for such values, but of course this change it not needed for the PR, so if you disagree with it I'll revert it. Also, given that minislate is not announced as stable we can tolerate such break of the API.