Log response body on event stream transport error#69
Merged
Conversation
- In EventStream::poll_next(), when the byte stream yields a reqwest error, log the full buffered body (self.buf) via tracing::warn! with error and body fields - Add test_event_stream_error_logs_body that creates a stream yielding partial data then a transport error, capturing the tracing output to verify the body appears in the log
olsonjeffery
force-pushed
the
task/6-bug-still-seeingerror-decoding
branch
from
July 23, 2026 21:31
e1aedff to
d1e9be8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When the SSE event stream's
bytes_stream()yields a reqwest transport error (typically a framing/connection issue), the current code discards the partially-received response body without logging it. This makes it impossible to diagnose the root cause from log output.Changes
src/opencode_sdk/client.rs: Addedtracing::warn!logging of the full buffered body (self.buf) inEventStream::poll_next()when the byte stream yieldsErr(e)Testing