Skip to content

Fix stale charge-limit threshold in battery status panel #356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jastincheis wants to merge 3 commits into
base: quattro
Choose a base branch
from
Open

Fix stale charge-limit threshold in battery status panel #356

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c2b842f
Fix stale charge-limit threshold in battery status panel
jastincheis Sep 6, 2026
771fc85
Merge branch 'quattro' into fix/battery-status-stale-threshold
malik-na Sep 10, 2026
199d989
Merge branch 'quattro' into fix/battery-status-stale-threshold
malik-na Sep 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions bin/omarchy-battery-status
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,13 +73,18 @@ power_rate=$(awk -v rate="${power_rate_raw:-0}" 'BEGIN {
print rounded
}')
state=$(awk '/state/ { print $2; exit }' <<<"$battery_info")
threshold_start=$(awk '/charge-start-threshold:/ { gsub(/%/, "", $2); print int($2); exit }' <<<"$battery_info")
threshold_end=$(awk '/charge-end-threshold:/ { gsub(/%/, "", $2); print int($2); exit }' <<<"$battery_info")

# The device's own sysfs directory first -- native-path names it, whatever it
# is called -- and only then the BAT* guess, which never matches macsmc-battery.
[[ -z $threshold_end ]] && threshold_end=$(cat "$battery_path"/charge_control_end_threshold 2>/dev/null | head -1)
[[ -z $threshold_start ]] && threshold_start=$(cat "$battery_path"/charge_control_start_threshold 2>/dev/null | head -1)
# is called. UPower's charge-*-threshold is only a fallback: the
# macsmc-battery driver never calls power_supply_changed() for a
# threshold-only write, so UPower's copy goes stale the moment
# battery-charge-limit changes it and never catches up (Panel.qml hits the
# same staleness for the slider and reads the CLI directly for that reason).
# The BAT* guess never matches macsmc-battery either way.
threshold_end=$(cat "$battery_path"/charge_control_end_threshold 2>/dev/null | head -1)
threshold_start=$(cat "$battery_path"/charge_control_start_threshold 2>/dev/null | head -1)
[[ -z $threshold_end ]] && threshold_end=$(awk '/charge-end-threshold:/ { gsub(/%/, "", $2); print int($2); exit }' <<<"$battery_info")
[[ -z $threshold_start ]] && threshold_start=$(awk '/charge-start-threshold:/ { gsub(/%/, "", $2); print int($2); exit }' <<<"$battery_info")
[[ -z $threshold_end ]] && threshold_end=$(cat "$power_supply_path"/BAT*/charge_control_end_threshold 2>/dev/null | head -1)
[[ -z $threshold_start ]] && threshold_start=$(cat "$power_supply_path"/BAT*/charge_control_start_threshold 2>/dev/null | head -1)

Expand Down
Loading