feat(hw): detect fingerprint readers beyond the USB bus - #411
Open
duketopceo wants to merge 1 commit into
Open
duketopceo wants to merge 1 commit into
duketopceo wants to merge 1 commit into
Conversation
omarchy-hw-fingerprint only scanned /sys/bus/usb, but nothing about a fingerprint sensor requires USB — a Touch ID driver on Apple Silicon, if one ever lands, would sit on the SoC's own fabric. Two more passes after the USB scan, both trusted only when a device names itself: - other buses: any non-USB sysfs device whose name, product, or modalias says fingerprint/biometric/touchid - fprintd: when its D-Bus service file exists, GetDevices is the authoritative usable-reader answer Both are skipped cleanly when nothing matches, so the command still works before fprintd is installed and stays silent on machines with no reader. Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
wesleygrimes
added
the
defer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
omarchy-hw-fingerprintonly scanned/sys/bus/usb, but nothing about a fingerprint sensor requires USB. This adds two passes after the USB scan so detection keeps working whatever bus a reader lands on:name/product/modaliassays fingerprint/biometric/touchid is trusted — no vendor list, since there's nothing to guess from. This is what would catch a Touch ID driver on Apple Silicon if one ever exists (today the sensor is Secure-Enclave-bound with no device-tree node, so nothing to drive — but when a driver appears,omarchy setup security fingerprintand the first-run invitation hook will just work).net.reactivated.Fprint.serviceis installed,GetDevicesis the authoritative usable-reader answer and catches sensors the sysfs scans miss. Skipped when fprintd isn't installed, preserving the works-before-setup contract.Verified on a 4.0.3-1 package install (MacBookPro18,1): exits 1 cleanly — no false positives from the SPMI PMIC,
aop-sensors-*IIO devices, or SPI input devices.Test plan
test/shell.d/hw-fingerprint-test.shextended: platform/SPI fingerprint-named devices detected, PMIC/IIO non-matches rejected, fprintd device-present and device-absent both honored (16/16 pass)Generated with Devin