fix(install): install the Spotify web app when no native client exists - #412
Open
duketopceo wants to merge 1 commit into
Open
fix(install): install the Spotify web app when no native client exists#412duketopceo wants to merge 1 commit into
duketopceo wants to merge 1 commit into
Conversation
omarchy-install-service-spotify ran omarchy-pkg-add and then unconditionally launched /usr/bin/spotify and claimed success. On systems the repos cannot serve (no aarch64 build exists), that printed "Spotify has been installed" followed by an App failure notification for a binary that never landed. When the spotify package is neither installed nor in the repos, install the Spotify web app instead — the Mac fork's intended client. The launcher gains a branch for the webapp's desktop file so SUPER+SHIFT+M opens it, and the menu row dims once either client is present. Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
wesleygrimes
added
the
defer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #317.
omarchy-install-service-spotifyranomarchy-pkg-add spotify, which skips the package via the ARM repo filter and exits 0 — then unconditionally launched/usr/bin/spotify(anApp failurenotification) and printed "Spotify has been installed."Since no aarch64 Spotify client exists, when the
spotifypackage is neither installed nor in the repos the installer now installs the Spotify web app (open.spotify.comviaomarchy-webapp-install, dashboard-icons artwork) — the fork's intended client per the intentional-divergences list — and launches it. Systems that can install the package keep the native path unchanged.Two supporting changes:
omarchy-launch-spotifygains a branch for~/.local/share/applications/Spotify.desktop, so SUPER+SHIFT+M opens the web app instead of re-running the installer. (Focus already worked — the webapp's class…open.spotify.com…matches the existing\bspotify\bregex.)pkg-present spotify || Spotify.desktop).Test plan
pacman -Si spotify→ absent): installer takes the webapp branch, callsomarchy-webapp-install Spotify https://open.spotify.com …, launches viaomarchy-launch-webapp, prints an honest messagebash -ncleanGenerated with Devin