fix(install): fail honestly when Dropbox cannot be installed - #413
Open
duketopceo wants to merge 1 commit into
Open
fix(install): fail honestly when Dropbox cannot be installed#413duketopceo wants to merge 1 commit into
duketopceo wants to merge 1 commit into
Conversation
omarchy-install-service-dropbox enabled the omarchy.dropbox bar widget even when every package it asked for was skipped by the repos filter, leaving a widget that reports "Dropbox CLI is not installed" forever. The dropbox daemon has no aarch64 build, so when dropbox-cli is neither installed nor repo-installable, say so and exit before touching the bar. Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
wesleygrimes
added
the
defer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #300.
The Dropbox installer enabled the
omarchy.dropboxbar widget even whenomarchy-pkg-addskipped every package in its list — on aarch64 all ofdropbox,dropbox-cli,libappindicator-gtk3, andnautilus-dropboxare AUR/x86-only names the repos filter drops. Users got a permanently-broken widget ("Dropbox CLI is not installed") and a fake success message.Since the Dropbox daemon has no aarch64 build at all, there's no fallback to offer — the script now checks
dropbox-cliinstallability up front, prints the real reason, and exits 1 before touching the bar. A machine wheredropbox-cliis already installed still proceeds, so nothing changes for a working setup.Test plan
bash -ncleanGenerated with Devin