fix(update): report dev-checkout updates at release granularity - #421
Open
duketopceo wants to merge 2 commits into
Open
fix(update): report dev-checkout updates at release granularity#421duketopceo wants to merge 2 commits into
duketopceo wants to merge 2 commits into
Conversation
The update check counted any commit HEAD was behind upstream, so the bar icon lit on every push between releases. Resolve the newest tag reachable from upstream and report only when HEAD does not contain it; keep the commit count as a fallback for upstreams with no tags. Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
wesleygrimes
added
the
cherry-pick-later
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #405.
omarchy-update-availablecounted commitsHEAD..upstream, so the bar's update icon lit on every push between releases. For dev checkouts this now resolves the newest tag reachable from upstream (git describe --tags --abbrev=0) and reports only when HEAD does not contain that release — matching the reporter's suggestion.Upstreams with no tags keep the existing commit-count behavior.
omarchy-update-devstillgit pull --ff-onlys on demand regardless of the icon, so nothing about updating changes.Test plan
test/shell.d/update-available-release-test.shbuilds a real bare-origin/clone pair: commits past the newest tag stay quiet, a new upstream tag reportsrelease v1.1, tagless upstream falls back to commit count, up-to-date stays quiet — 4/4 passv4.0.2-2→ quiet despite being behindorigin/quattroGenerated with Devin