Conversation
BCM4388 (14e4:4434) wedges on real lid-close suspend just like the other parts. The single s2idle test that excluded it did not reproduce the real-world path. Covers omacom#10857.
malik-na
added
the
lvl 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BCM4388 (
14e4:4434) wedges on real lid-close suspend just like BCM4378/BCM4387 — scans fail and every association is rejected until the driver reloads. Adds4434to the installer leaf gate and the existing-install migration, which was deliberately excluding it based on a single six-minute s2idle test on an M2 Max (PR #255 review) that did not reproduce the real-world lid-close path.The recovery command itself is unchanged: it stays a no-op on machines where the firmware does not wedge (wedge signature + backstop + radio-disabled guard).
Test plan
test/shell.d/wifi-resume-fix-test.sh: BCM4388 on aarch64 now asserts service install + enable; x86_64 with 4434 still skipped; migration installs for aarch64/4434. All 21 assertions pass.bash -nclean on leaf, migration, command, and test.Relates to omacom#10857.