Allow derived bars to provide a passive background component - #11103
Open
adamritter wants to merge 1 commit into
Open
Allow derived bars to provide a passive background component#11103adamritter wants to merge 1 commit into
adamritter wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Derived bar plugins currently need to duplicate Bar.qml to change how its background is painted. Add an optional
backgroundComponentso they can inherit the stock bar's widgets, layout, input handling and multi-monitor behavior while supplying their own passive background.Each monitor gets its own disabled Loader beneath the widgets, with the bar's background color, position and orientation exposed as context properties. Null keeps the existing theme fill, and transparent mode unloads the custom background. No appearance change for existing bars. Includes a usage example and focused QML tests.
Validation:
./test/all: six shell test files fail on this machine (config,launch-about,locate,network-qr,snapper,unowned-system-paths). Re-ran each against the unmodified base and reproduced all six failures; some require the separate packaging checkout. Relevant bar tests pass.Visual verification
Actual desktop captures of the same derived bar with the stock clock, on an empty workspace. Cropped to the bar and wallpaper immediately below it.
Custom gradient supplied through
backgroundComponentTransparent mode: custom background unloaded
Component removed: stock theme fill restored