Allow annotations to start outside the canvas - #108
Open
jondkinney wants to merge 4 commits into
Open
Conversation
jondkinney
force-pushed
the
feat/off-canvas-annotations
branch
from
September 5, 2026 16:46
ad1f316 to
58227d6
Compare
There was a problem hiding this comment.
🟡 Changes recommended
Chrome hit-testing and incremental marker preview repainting have unresolved correctness issues.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Enables annotations to begin in the workspace surrounding a screenshot and expand the canvas.
Changes:
- Adds off-canvas creation rules and previews while restricting source-based tools.
- Adds smoke coverage for creation, undo, and boundary behavior.
- Documents the expanded workspace behavior.
File summaries
| File | Description |
|---|---|
src/editor.cpp |
Implements off-canvas creation and rendering. |
src/editor.hpp |
Declares workspace hit-testing helpers. |
tests/editor-smoke.cpp |
Tests off-canvas workflows and restrictions. |
README.md |
Documents canvas growth behavior. |
Review details
Suppressed comments (1)
src/editor.cpp:6297
- The marker ghost can now be painted outside
editImageRect(), butpointerMotionRegion()still adds the marker’s actual bounds only wheneditImageRect().contains(point)(line 4162). Mouse movement uses partial repaint regions, so a large or zoomed marker in the new workspace can be clipped or leave stale pixels; this smoke test’sgrab()forces a full repaint and masks the problem. Use the samecanStartAnnotationAt(point)predicate in marker damage calculation.
const bool markerPreview = tool_ == Tool::Marker && !dragging_ &&
canStartAnnotationAt(cursor_) &&
!pointerGrabsLayer();
const bool markerPreviewOutsideCanvas =
markerPreview && !image.contains(cursor_);
- Files reviewed: 4/4 changed files
- Comments generated: 1
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+1879
to
+1896
| bool CaptureEditor::canStartAnnotationAt(const QPointF &position) const { | ||
| if (requiresSourcePixels(tool_)) | ||
| return sourceFrameWidgetRect().contains(position); | ||
| if (editImageRect().contains(position)) | ||
| return true; | ||
| if (canvasBoundaryMode_ == CanvasBoundaryMode::Image || | ||
| !supportsOffCanvasCreation(tool_) || | ||
| !annotationWorkspaceRect().contains(position)) | ||
| return false; | ||
| // Popovers overlap the content band. Their buttons are handled before the | ||
| // workspace, while their padding must remain chrome rather than canvas. | ||
| if ((colorPaletteOpen_ && colorPaletteRect().contains(position)) || | ||
| (customColorPickerOpen_ && customColorPanelRect().contains(position)) || | ||
| (shapeMenuOpen_ && shapeMenuRect().contains(position)) || | ||
| (textSizeMenuOpen_ && textSizePanelRect().contains(position))) | ||
| return false; | ||
| return true; | ||
| } |
There was a problem hiding this comment.
🟡 Changes recommended
An in-flight highlighter probe can incorrectly affect an off-canvas stroke.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 1
- Review effort level: Balanced
Comment on lines
5465
to
5469
| } else if (canStartAnnotationAt(cursor_)) { | ||
| scheduleHighlighterProbe(toUnclampedAnnotationPoint(cursor_)); | ||
| } else { | ||
| clearHighlighterPreview(); | ||
| } |
There was a problem hiding this comment.
🟡 Changes recommended
Right-side off-canvas text is constrained to a 48-pixel editor and becomes clipped while typing.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 1
- Review effort level: Balanced
| case CaptureEditor::Tool::Marker: | ||
| case CaptureEditor::Tool::Rectangle: | ||
| case CaptureEditor::Tool::Ellipse: | ||
| case CaptureEditor::Tool::Text: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
make check