Skip to content

feat(editor): reveal saved screenshots in Files - #115

Open
devmobasa wants to merge 2 commits into
omacom:mainfrom
devmobasa:feat/reveal-saved-screenshot
Open

feat(editor): reveal saved screenshots in Files#115
devmobasa wants to merge 2 commits into
omacom:mainfrom
devmobasa:feat/reveal-saved-screenshot

Conversation

@devmobasa

Copy link
Copy Markdown
Contributor

What changed

Adds two ways to reveal a saved screenshot in Files:

  • Hold Shift while saving:
    • Ctrl+Shift+S
    • Shift+Enter
    • Shift-click Save or Copy+Save
  • Click the saved-capture notification’s “Click to show in folder” action.

Files opens with the screenshot selected. Normal save behavior remains unchanged and does not open
Files automatically.

Implementation

  • Uses uwsm-app -- nautilus --select <file-url>.
  • Runs reveal work outside the UI thread.
  • Treats reveal failure as non-fatal; the screenshot remains saved.
  • Converts relative output destinations to absolute file URLs before invoking Files.
  • Reuses one reveal implementation for keyboard, toolbar, and notification actions.

The notification action previously reopened the exported image in Omasnap. Editable captures remain
available from the Recent captures shelf.

Testing

Added smoke coverage for:

  • Ctrl+Shift+S
  • Shift+Enter
  • Shift-click Save
  • Shift-click Copy+Save
  • Normal save without immediate reveal
  • Notification reveal arguments
  • Relative screenshot destinations
  • Absolute notification image and reveal paths

make check passes.

@tobi
tobi requested a balanced review from Copilot August 31, 2026 16:30

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The detached-command log synchronization can make the new smoke test intermittently read incomplete arguments.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Adds asynchronous screenshot reveal support through Nautilus, available via Shift-modified saves and notification actions.

Changes:

  • Adds shared file-reveal command handling.
  • Integrates reveal gestures into editor shortcuts and toolbar actions.
  • Updates documentation and smoke coverage.
File summaries
File Description
src/capture.cpp Implements reveal and notification commands.
src/capture.hpp Exposes the reveal helper.
src/editor.cpp Connects reveal gestures to saving.
src/editor.hpp Updates editor method signatures.
tests/editor-smoke.cpp Tests reveal flows and arguments.
README.md Documents commands and shortcuts.
docs/dependencies.md Documents optional reveal dependencies.
Review details
  • Files reviewed: 7/7 changed files
  • Comments generated: 1
  • Review effort level: Balanced

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread tests/editor-smoke.cpp Outdated

@tobi tobi left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed against current main and tested as part of the combined integration check. Process launch stays on the export worker and uses the current safe argv notification action.

test(editor): publish reveal smoke logs atomically

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants