feat(chrome): split the capture tab strip around the MacBook notch - #121
Open
wesleygrimes wants to merge 1 commit into
Open
feat(chrome): split the capture tab strip around the MacBook notch#121wesleygrimes wants to merge 1 commit into
wesleygrimes wants to merge 1 commit into
Conversation
wesleygrimes
changed the title
wesleygrimes
force-pushed
the
feat/notch-chrome-ears
branch
from
September 11, 2026 23:56
f28947b to
f7834f2
Compare
wesleygrimes
changed the title
wesleygrimes
force-pushed
the
feat/notch-chrome-ears
branch
2 times, most recently
from
September 12, 2026 00:31
fdc2ca0 to
e08d7b7
Compare
wesleygrimes
changed the title
On the notched MacBook Pro panels (native 3456×2234 and 3024×1964) the tab strip sat under the camera housing. Derive the housing width from the monitor mode and lay the tabs out as two ears either side of it; every other monitor keeps the centered strip unchanged.
wesleygrimes
force-pushed
the
feat/notch-chrome-ears
branch
from
September 12, 2026 00:36
e08d7b7 to
f8f7dc8
Compare
wesleygrimes
marked this pull request as ready for review
September 12, 2026 00:37
Author
|
@tobi love omasnap, was using it on my m2 macbook and noticed an issue with the controls being hidden behind the notch. Thoughts on including this change? Happy to tweak the PR as well if you wanna go a different direction. Went with resolution detection because these resolutions should be specific to the notched MacBook Pro panels; an identical custom or virtual monitor mode would also trigger the split layout, but pretty unlikely. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On the notched MacBook Pro panels under Asahi (native
3456×2234/3024×1964) the capture tab strip sits under the camera housing, so the Window / Scrolling Region tabs are partly hidden.captureTabNotchWidth()derives the housing width from the monitor mode — no config, nothing to set up.captureTabLayout()takes that width and lays the tabs out as two ears either side of the housing;drawCaptureTabs()paints one bar per ear.0and the exact centered layout as before. The edit toolbar is untouched.Photos
Before — tabs under the notch.
After — tabs either side of it; toolbar unchanged.
Test plan
make checkgreen