Fix bridged startup and private Ninja test execution - #202
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix two startup/build failures introduced in #198 and #201:
execinside command substitution so the networking client remains a direct child of the launcher under macOS/bin/bash. This preserves the process chain required by the privileged daemon without weakening authorization.--no-rebuildafter the explicit private-Ninja build. Clean machines no longer need a globally installed Ninja to run those tests.Validation:
qemu_network_startunder/bin/bashwith a native client stub that checks its parent PID. It fails before the fix and passes afterward.PATH, the old command exits 127 and the fixed command passes.make testpassed.A complete QEMU runtime rebuild and privileged bridged-VM launch were not performed for this change.