io: parse metadata through otherData field#9
Open
sluongng wants to merge 1 commit intoomaskery:masterfrom
Open
io: parse metadata through otherData field#9sluongng wants to merge 1 commit intoomaskery:masterfrom
sluongng wants to merge 1 commit intoomaskery:masterfrom
Conversation
omaskery
reviewed
Feb 19, 2022
Owner
omaskery
left a comment
omaskery
left a comment
There was a problem hiding this comment.
This looks good to me. As per your question on the linked issue: I think that complying with the spec and naming it OtherData would be a good idea, so I'll not mark this as approved yet.
I'd recommend leaving the existing public accessor on TefData as Metadata() though to preserve API compatibility, add a Deprecated: ... comment (as described in here), and just add a new accessor to the same data called OtherData(), then if this ever gets a major version bump we can just delete the Metadata() one.
Thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes: #8