Skip to content

cache maven dependencies - #1

Closed
jburel wants to merge 1 commit into
ome:mainfrom
jburel:cache
Closed

cache maven dependencies#1
jburel wants to merge 1 commit into
ome:mainfrom
jburel:cache

Conversation

@jburel

@jburel jburel commented Jun 9, 2022

Copy link
Copy Markdown
Member

This indicates to use the maven cache.
See https://github.com/actions/setup-java#caching-packages-dependencies

@jburel
jburel requested a review from sbesson June 9, 2022 09:56
@sbesson

sbesson commented Jun 9, 2022

Copy link
Copy Markdown
Member

I am a bit unclear about the idea of caching dependencies. ome/openmicroscopy#6324 has certainly demonstrated that some of our components require testing with a populated cache although it might be limited to this specific component and the usage of the Ivy dependency system.

On the flip side, we want some coverage for building individual components from a clean state to detect dependency issues (like in the case of ome/omero-model#80). What is the primary benefit of activating the Java cache and where would you see it being used?

@jburel

jburel commented Jun 9, 2022

Copy link
Copy Markdown
Member Author

actually I opened it and tested it. It did not do what I was expecting;
Closing this PR

@jburel jburel closed this Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants