Skip to content

Introducing Trending Dark Mode #3

Open
saif71 wants to merge 15 commits into
omicronlab:masterfrom
saif71:master
Open

Introducing Trending Dark Mode #3
saif71 wants to merge 15 commits into
omicronlab:masterfrom
saif71:master

Conversation

@saif71

@saif71 saif71 commented Apr 1, 2019

Copy link
Copy Markdown
  1. Dark Mode Added
  2. Updated Readme.md
  3. Added Informative badges

@mugli

mugli commented Apr 2, 2019

Copy link
Copy Markdown
Member

Could you provide a screenshot for the visual changes?

@mugli
mugli requested a review from torifat April 2, 2019 06:18
@saif71

saif71 commented Apr 2, 2019

Copy link
Copy Markdown
Author

Could you provide a screenshot for the visual changes?

Sure. Here they are.
screenshots

also for demonstration purpose I've deployed it on :
https://avro.netlify.com/

@saif71

saif71 commented Apr 2, 2019

Copy link
Copy Markdown
Author

Dear concern,
I've also created a browser extension for chrome. Please let me know your thoughts.
https://github.com/saif71/avro-for-chromium

@sarim

sarim commented Apr 2, 2019

Copy link
Copy Markdown
Member

few technical problems.

  1. app manifest producing a 404 error and/or not working properly in your deployment.
  2. Loader (loading for the last time) related stylesheet needs to remain in index.html. If the browsers needs to wait for another stylesheet to download, it kinda defeats the purpose of loader doesn't it?
  3. There is probably room for improvement in the code for swapping themes. Right now it glitches to no stylesheet for a brief second before the theme is loaded.

@saif71

saif71 commented Apr 2, 2019

Copy link
Copy Markdown
Author

few technical problems.

  1. app manifest producing a 404 error and/or not working properly in your deployment.
  2. Loader (loading for the last time) related stylesheet needs to remain in index.html. If the browsers needs to wait for another stylesheet to download, it kinda defeats the purpose of loader doesn't it?
  3. There is probably room for improvement in the code for swapping themes. Right now it glitches to no stylesheet for a brief second before the theme is loaded.

those issues has been resolved . Please check. :)

@mugli
mugli requested a review from sarim April 3, 2019 07:04
@mugli

mugli commented Apr 3, 2019

Copy link
Copy Markdown
Member

Ping @sarim. Will merge and deploy after getting lgtm from you.

@sarim

sarim commented Apr 7, 2019

Copy link
Copy Markdown
Member

Doesn't work after building - gulp build. Build process concentrates all css files into one, and your theme changing js doesn't work after that. Don't do theme switch using javascript based stylesheet change, rather include both themes in css under a prefix/class name. toggle the classname on body.
ex:

<body class="theme-dark"

@sarim

sarim commented Apr 7, 2019

Copy link
Copy Markdown
Member

@saif71

saif71 commented Apr 7, 2019

Copy link
Copy Markdown
Author

Ok. I'm checking the issues .

@saif71

saif71 commented Apr 7, 2019 •
edited
Loading

Copy link
Copy Markdown
Author

Doesn't work after building - gulp build. Build process concentrates all css files into one, and your theme changing js doesn't work after that. Don't do theme switch using javascript based stylesheet change, rather include both themes in css under a prefix/class name. toggle the classname on body.
ex:

<body class="theme-dark"

@sarim
Issues has been resolved. Please check the latest commit.

@saif71

saif71 commented May 22, 2019

Copy link
Copy Markdown
Author

vai,
did you get the chance to review the latest codes ? :)

@khaled-0

khaled-0 commented Apr 11, 2022

Copy link
Copy Markdown

@sarim

@axif0

axif0 commented Jul 14, 2025

Copy link
Copy Markdown

Any thoughts on this PR? 👀

@anisul anisul mentioned this pull request Jul 17, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@torifat torifat Awaiting requested review from torifat
@sarim sarim Awaiting requested review from sarim

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@saif71 @mugli @sarim @khaled-0 @axif0