refactor!: unified extra kernel args and handling for pstore (rpi & tauri)#654
Merged
HarryWaschkeit merged 4 commits intoJun 2, 2026
Conversation
Previouslyi, the CMDLINE mechanism was used to set suitable kernel arguments for reboot reason feature (pstore) handling what is actually the standard way in the Raspberry Pi BSP. However, the standard omnect OS way is to use the APPEND mechanism which gets applied to arbitrary bootloaders. Signed-off-by: Harry Waschkeit <44188360+HarryWaschkeit@users.noreply.github.com>
mlilien
reviewed
May 26, 2026
Contributor
mlilien
left a comment
There was a problem hiding this comment.
please add to the description that this PR enforces a rpi bootloader update
Signed-off-by: Harry Waschkeit <44188360+HarryWaschkeit@users.noreply.github.com>
Signed-off-by: Harry Waschkeit <44188360+HarryWaschkeit@users.noreply.github.com>
Signed-off-by: Harry Waschkeit <44188360+HarryWaschkeit@users.noreply.github.com>
mlilien
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the CMDLINE mechanism was used to set suitable kernel arguments for reboot reason (feature pstore) handling what is actually the standard way in the Raspberry Pi BSP.
However, the standard omnect OS way is to use the APPEND mechanism which gets applied to arbitrary bootloaders.
Moreover, for tauri there was an unnecessary ramoops setting (use of ECC) part of the kernel arguments, because it is already part of the device tree add-on that was introduced for reboot reason support.
BREAKING CHANGE: this forces a boot loader update on Raspberry Pi 4.