fix(preview-ui): derive websocket port from the serving origin - #132
Merged
Conversation
The websocket URL hardcoded port 3000, so an instance started with `--port <n>` served its UI correctly but connected to whatever backend happened to be on 3000 — showing the wrong workspace, or failing to connect at all. Use `window.location.host`, which already carries the port. `vite dev` is unaffected: vite.config.ts proxies /ws to localhost:3000, so the URL resolves to the dev server and is forwarded from there. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The websocket URL hardcoded port 3000, so an instance started with
--port <n>served its UI correctly but connected to whatever backend happened to be on 3000 — showing the wrong workspace, or failing to connect at all.Use
window.location.host, which already carries the port.vite devis unaffected: vite.config.ts proxies /ws to localhost:3000, so the URL resolves to the dev server and is forwarded from there.