Fix altitude loss detector key hold#14
Merged
Merged
Conversation
The `KeyHold` utility class was using static fields and methods, which caused issues when multiple key holds were active at the same time. This could lead to the key being held indefinitely. This commit refactors the `KeyHold` class to be instance-based. Each call to `KeyHold.hold` now creates a new instance of the class, which manages its own state and lifecycle. The instance subscribes to the event bus on creation and unsubscribes on release, ensuring that the key is correctly released after the specified duration.
The `KeyHold` utility was interpreting the duration parameter as seconds instead of ticks, causing the altitude loss detector to be disabled for an extended period. This commit corrects the `KeyHold` class to interpret the duration as ticks, ensuring the detector resets correctly. This also includes the previous fix that refactored `KeyHold` to be instance-based, preventing indefinite key holds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.