Fix mixin crash and whole module lol#21
Merged
Merged
Conversation
Removes the emergency disconnect functionality from the Auto Elytra Repair module. The module will no longer disconnect the player if it fails to find a safe landing spot after a set number of attempts. Instead, it will now continuously expand its search radius and keep trying to find a landing spot indefinitely. This change also fixes a bug where the expanding search radius was calculated but not correctly used in the landing spot search function.
The `PlayerInventoryAccessor` mixin was using an explicit field name in the `@Accessor` annotation, which caused a runtime error after a Minecraft update. By removing the explicit field name, the Mixin framework can now correctly infer the target field from the accessor method's name, making the code more robust and resilient to future updates.
This commit overhauls the auto-repair and flight resume systems to be more robust and efficient. Key changes: - The elytra repair logic now continuously throws XP bottles until the elytra is fully repaired or the player runs out of bottles, replacing the old inefficient timer-based system. - The takeoff sequence after a repair is now managed by a state machine that checks the player's vertical velocity, making it more reliable than the previous timer-based implementation. - A new "climbing" state has been added to the flight controller. After a repair, the bot will now climb back to the target flight altitude before resuming its path. - The default flight altitude has been changed to 160 blocks as requested. - A compilation error related to accessing a private field in `PlayerInventory` has been fixed.
This commit overhauls the auto-repair and flight resume systems to be more robust and efficient. Key changes: - The elytra repair logic now continuously throws XP bottles until the elytra is fully repaired or the player runs out of bottles, replacing the old inefficient timer-based system. - The takeoff sequence after a repair is now managed by a state machine that checks the player's vertical velocity, making it more reliable than the previous timer-based implementation. - A new "climbing" state has been added to the flight controller. After a repair, the bot will now climb back to the target flight altitude before resuming its path. - The default flight altitude has been changed to 160 blocks as requested. - A compilation error related to accessing a private field in `PlayerInventory` has been fixed. - Fixed a `NullPointerException` caused by a missing null check when accessing the `autoElytraRepair` module.
This commit overhauls the auto-repair and flight resume systems and fixes a critical bug in the safe landing logic. Key changes: - The safe landing logic in `SafeLandingSpotFinder.java` has been fixed to explicitly check for water, preventing the bot from landing in oceans. - The elytra repair logic now continuously throws XP bottles until the elytra is fully repaired or the player runs out of bottles. - The takeoff sequence after a repair is now managed by a state machine that checks the player's vertical velocity, making it more reliable. - A new "climbing" state has been added to the flight controller to ensure the bot returns to the target flight altitude after repairs. - The default flight altitude has been changed to 160 blocks as requested. - Fixed a `NullPointerException` caused by a missing null check.
This commit addresses several issues with the auto-repair system, including fixing a crash, preventing ocean landings, and making the flight resume process more reliable. Key changes: - Fixed a bug that caused the bot to get stuck during descent by ensuring movement is active during the landing sequence. - Added an explicit check for water in `SafeLandingSpotFinder.java` to prevent the bot from landing in oceans. - Refactored the elytra repair logic to continuously use XP bottles until the elytra is fully repaired. - Overhauled the takeoff sequence to be state-based instead of timer-based for better reliability. - Added a "climbing" state to ensure the bot returns to the target flight altitude after repairs. - Set the default flight altitude to 160 as requested. - Fixed an initial `InvalidAccessorException` crash and a subsequent `NullPointerException`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.