Fix elytra break detection webhook#5
Merged
Conversation
The elytra check in BaseFinderModule was only checking if the chest slot was empty. This caused the webhook notification to not fire when an elytra would break mid-flight. This change modifies the check to also consider an elytra as "out" if it is damaged to the point of being broken. The Discord notification and disconnect messages have been updated to be more descriptive.
The elytra break detection was too aggressive and would disconnect the player immediately. This change introduces a 2-second leeway to allow for auto-equip plugins to replace a broken elytra before disconnecting. A tick counter has been added to track the time since an elytra has been unusable. The disconnect logic is now only triggered if the counter exceeds 40 ticks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.