📱 fix responsive issue on contact button #312
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Member
|
We still have the old commits on this one |
jcailly
force-pushed
the
jcailly/fix-responsive-on-contact-button
branch
from
8fe5e0d to
81630f6
Compare
Member
📝 Changed routes:
Commit 81630f6 (https://onruntime-website-kc6kfx1xc-onruntime.vercel.app). |
![Screenshot of /agency/[city]](https://images.weserv.nl?url=https://sjc.microlink.io/0y6F3Q1Ao3AG69FwWc1oG9Y2ADqFTl1ZOaV2Sj1jNWFhrTLZsDB3N9SkpFuw_pFlbgSiO8ss9txT5b1uXVQvgA.png&w=600)
Contributor
Author
|
I've corrected the commit |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses a responsive design issue by adjusting the font size of the "Discuter de votre projet" button at a custom screen width of 480px and enhances layout consistency.
- Adds an "xs" screen breakpoint at 480px in the Tailwind configuration.
- Updates the contact CTA component to apply responsive text classes by wrapping the Link with a Button using the asChild prop.
- Applies a full-width class in the agency page to ensure a consistent container width.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tailwind.config.ts | Added custom "xs" breakpoint at 480px to support responsive design. |
| src/components/marketing/agency/contact-cta.tsx | Modified button structure and applied responsive text size classes for the contact button. |
| src/app/agency/[city]/page.tsx | Added a full-width class to the main element to improve layout consistency. |
Comments suppressed due to low confidence (2)
src/components/marketing/agency/contact-cta.tsx:49
- The responsive text size classes (text-md and xs:text-lg) override the default button size. Please add a comment or update documentation to clearly explain the intended behavior in relation to the button's size prop.
<Button asChild size="lg" className="text-md xs:text-lg">
src/app/agency/[city]/page.tsx:75
- Verify that adding the 'w-full' class to the main tag aligns with the overall layout design and does not adversely affect container widths on larger screens.
<main className="min-h-screen pt-32 pb-16 w-full">
Asma-95
approved these changes
Jul 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modification fix responsive issue for "Discuter de votre projet" button by reducing text size from lg to md at a custom screen width of 480px.