fix: align timeline component dimensions based on size prop#49
Open
hitomihiumi wants to merge 2 commits intoonce-ui-system:mainfrom
Open
fix: align timeline component dimensions based on size prop#49hitomihiumi wants to merge 2 commits intoonce-ui-system:mainfrom
hitomihiumi wants to merge 2 commits intoonce-ui-system:mainfrom
Conversation
|
@hitomihiumi is attempting to deploy a commit to the Dopler Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Pull request overview
This PR refactors the Timeline component’s sizing/spacing logic (introducing shared size/offset tokens and some horizontal padding tweaks) and updates the Text component documentation to remove the deprecated/unsupported type prop from the API reference.
Changes:
- Refactor
Timelinemarker sizing and offset calculations into shareddimensionSize/topOffsetvalues. - Adjust
Timelinemarker container spacing (e.g., marginTop and horizontal edge padding) and reformat conditional props for readability. - Remove
typefrom the Text docs API reference table.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/core/src/components/Timeline.tsx | Refactors marker sizing/offset handling and adjusts layout props for vertical/horizontal timeline rendering. |
| apps/docs/src/content/once-ui/components/text.mdx | Updates Text component API reference to remove type prop. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| const dimensionSize = | ||
| size === "xs" ? "8" : size === "s" ? "24" : size === "m" ? "32" : size === "l" ? "40" : "48"; | ||
| const topOffset = | ||
| size === "xs" ? "20" : size === "s" ? "12" : size === "m" ? "8" : size === "l" ? "4" : "0"; |
Comment on lines
321
to
329
| <PropsTable | ||
| content={[ | ||
| ["as", "ElementType", `"span"`], | ||
| ["variant", "TextVariant"], | ||
| ["size", ["xs", "s", "m", "l", "xl"]], | ||
| ["weight", ["default", "strong"]], | ||
| ["type", ["display", "heading", "body", "label", "code"]], | ||
| ["family", ["display", "heading", "body", "label", "code"]], | ||
| ["onBackground", "`${ColorScheme}-${ColorWeight}`"], | ||
| ["onSolid", "`${ColorScheme}-${ColorWeight}`"], |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The indentation height is now dynamic and depends on the size of the marker. #43
Without fix:
With fix:
