feat: update onBackground prop for text color styling#51
Open
divyanshudhruv wants to merge 1 commit intoonce-ui-system:mainfrom
Open
feat: update onBackground prop for text color styling#51divyanshudhruv wants to merge 1 commit intoonce-ui-system:mainfrom
divyanshudhruv wants to merge 1 commit intoonce-ui-system:mainfrom
Conversation
|
@divyanshudhruv is attempting to deploy a commit to the Dopler Team on Vercel. A member of the Team first needs to authorize it. |
Member
|
@divyanshudhruv while its gettinbg merged you can temporary add an onBackground="neutral-strong" to the StylePanel component and the text will inherit the style ^^ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updated text color styling by modifying the
onBackgroundprop to use the proper color systemChanges
onBackgroundprop usage in text components for consistent color themingStylePanel.tsxcomponentTesting