feat: lock naked aura - #3
Merged
Merged
Conversation
Xeonus
approved these changes
Aug 4, 2025
Xeonus
left a comment
Xeonus
left a comment
There was a problem hiding this comment.
- correct locker address
- handles AURA locking in wallet
- updating safe interface
- linting
jubeira
reviewed
Aug 6, 2025
jubeira
left a comment
jubeira
left a comment
Contributor
There was a problem hiding this comment.
I don't have all the context, but the code and the test looks correct in principle.
Not sure whether you want to handle both operations whenever possible in performUpkeep, but I've left a suggestion in case you want to explore that option.
Co-authored-by: Juan Ignacio Ubeira <juani@balancerlabs.dev>
gosuto-inzasheru
marked this pull request as ready for review
August 7, 2025 12:58
Contributor
Author
|
@Xeonus mind giving it one last look? |
Xeonus
approved these changes
Aug 11, 2025
Xeonus
left a comment
Xeonus
left a comment
There was a problem hiding this comment.
In general LGTM. Tests also consistent and cover most scenarios!
Minor comment:
- Checkupkeep returns true for any of the 2 conditions (relock or naked Aura, whichever comes first). However, perform upkeep handles both transactions. Logic and tests correctly handle the scenarios though (only lock naked Aura, don't relock, etc).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
still needs tests