Skip to content

tui: show friendly location badge instead of truncated model dir#3

Closed
keypair34 wants to merge 1 commit into
feature/agentic-engineeringfrom
fix/issue-2-truncated-model-dir
Closed

tui: show friendly location badge instead of truncated model dir#3
keypair34 wants to merge 1 commit into
feature/agentic-engineeringfrom
fix/issue-2-truncated-model-dir

Conversation

@keypair34

@keypair34 keypair34 commented Jun 27, 2026

Copy link
Copy Markdown
Collaborator

Summary

Fixes #2.

On the fine-tune "done" screen, the Adapter path field and the "Merged →" line printed raw absolute paths. The TUI fields are narrow, so those paths got cut off mid-string into things like /Users/setoelkahfi/Library/Group or …/Library/Group Containers/gro, which tells you nothing.

This shows an [Onde Inference] badge instead. It reuses the same path classification the GGUF detail screen already does through location_label(). The Adapter box keeps the file name too, so you can still tell which artifact it is.

Changes

  • src/app.rs: pulled the path-to-label logic out of AdapterEntry::location_label into a location_label_for_path() free function. location_label now calls it.
  • src/ui.rs: the fine-tune "done" screen renders [Onde Inference] lora_adapter.safetensors in the Adapter box and Merged → [Onde Inference] instead of the cut-off paths.

Before / After

Before:

Adapter
/Users/setoelkahfi/Library/Group        <- truncated
✓ Merged → /Users/setoelkahfi/Library/Group Containers/gro   <- truncated

After:

Adapter
[Onde Inference]  lora_adapter.safetensors
✓ Merged → [Onde Inference]

Testing

  • cargo build passes
  • cargo clippy --all-targets is clean

🤖 Generated with Claude Code

The fine-tune "done" screen rendered the raw absolute adapter path and the
merged-model path, which truncate to gibberish (e.g. ".../Library/Group") in
the narrow TUI fields. Show a friendly "[Onde Inference]" badge (plus the file
name for the adapter) instead, reusing the same classification the GGUF detail
screen already uses.

Extracts the path-to-label logic from AdapterEntry::location_label into a
reusable location_label_for_path() free function.

Fixes #2

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@setoelkahfi

Copy link
Copy Markdown
Collaborator

Reopening under the correct author account (setoelkahfi). Superseded by a new PR for the same branch.

@setoelkahfi setoelkahfi deleted the fix/issue-2-truncated-model-dir branch June 27, 2026 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants