tui: show friendly location badge instead of truncated model dir#3
Closed
keypair34 wants to merge 1 commit into
Closed
tui: show friendly location badge instead of truncated model dir#3keypair34 wants to merge 1 commit into
keypair34 wants to merge 1 commit into
Conversation
The fine-tune "done" screen rendered the raw absolute adapter path and the merged-model path, which truncate to gibberish (e.g. ".../Library/Group") in the narrow TUI fields. Show a friendly "[Onde Inference]" badge (plus the file name for the adapter) instead, reusing the same classification the GGUF detail screen already uses. Extracts the path-to-label logic from AdapterEntry::location_label into a reusable location_label_for_path() free function. Fixes #2 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Collaborator
|
Reopening under the correct author account (setoelkahfi). Superseded by a new PR for the same branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2.
On the fine-tune "done" screen, the Adapter path field and the "Merged →" line printed raw absolute paths. The TUI fields are narrow, so those paths got cut off mid-string into things like
/Users/setoelkahfi/Library/Groupor…/Library/Group Containers/gro, which tells you nothing.This shows an
[Onde Inference]badge instead. It reuses the same path classification the GGUF detail screen already does throughlocation_label(). The Adapter box keeps the file name too, so you can still tell which artifact it is.Changes
src/app.rs: pulled the path-to-label logic out ofAdapterEntry::location_labelinto alocation_label_for_path()free function.location_labelnow calls it.src/ui.rs: the fine-tune "done" screen renders[Onde Inference] lora_adapter.safetensorsin the Adapter box andMerged → [Onde Inference]instead of the cut-off paths.Before / After
Before:
After:
Testing
cargo buildpassescargo clippy --all-targetsis clean🤖 Generated with Claude Code