FEATURE - Toolbar scrollable - #84
Open
GIGAMOLE wants to merge 2 commits into
Open
Conversation
Author
|
By the way, who wants to use this feature, I created a separated remote dependency, while this PR is under review: Add it in your root build.gradle at the end of repositories: all projects {
repositories {
...
maven { url 'https://jitpack.io' }
}
}Step 2. Add the dependency dependencies {
implementation 'com.github.GIGAMOLE:ComposeCollapsingToolbar:latest-version'
}Or you can simply download it from there: https://github.com/GIGAMOLE/ComposeCollapsingToolbar/releases |
GIGAMOLE
force-pushed
the
feature/toolbar-scrollable
branch
from
May 8, 2023 18:47
36fe670 to
eca590f
Compare
Author
|
Fixed the issue with forced
|
GIGAMOLE
force-pushed
the
feature/toolbar-scrollable
branch
from
May 8, 2023 20:39
eca590f to
2fb821a
Compare
onebone
added
feature
…ollable # Conflicts: # README.md # lib/src/main/java/me/onebone/toolbar/CollapsingToolbarScaffold.kt # lib/src/main/java/me/onebone/toolbar/ToolbarWithFabScaffold.kt
Author
TODO:Currently, there is no toolbar scroll limitation for each scroll type. After the merge of the Snapping Feature: #83, it will be possible to track whether the offset or toolbar is scrolling to handle properly the toolbar scroll for each scroll strategy. |
|
I also need this change. Hopefully this gets merged asap. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By default,
CollapsingToolbaris not scrollable. In order to enable it, settoolbarScrollable = trueinCollapsingToolbarScaffold.Preview: