FEATURE - Enabled scroll when body is unfilled - #85
Open
GIGAMOLE wants to merge 1 commit into
Open
Conversation
Author
TODO:Currently automatic expending happened only in |
Author
|
By the way, who wants to use this feature, I created a separated remote dependency, while this PR is under review: Add it in your root build.gradle at the end of repositories: all projects {
repositories {
...
maven { url 'https://jitpack.io' }
}
}Step 2. Add the dependency dependencies {
implementation 'com.github.GIGAMOLE:ComposeCollapsingToolbar:latest-version'
}Or you can simply download it from there: https://github.com/GIGAMOLE/ComposeCollapsingToolbar/releases |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By default,
CollapsingToolbarScaffoldis scrollable when the body content is unfilled (basically the scrollable body content withoutModifier.fillMaxHeight()/Modifier.fillMaxSize()). In order to disable the scroll only when body content is unfilled, setenabledWhenBodyUnfilled = falseinCollapsingToolbarScaffold. Also note that if theCollapsingToolbaris collapsed when the body content becomes unfilled, it will be automatically expanded.Preview: