feat: angular 21generator#348
Draft
prathamMalavi wants to merge 8 commits into
Draft
Conversation
mollend0
reviewed
May 11, 2026
mollend0
reviewed
May 11, 2026
Contributor
|
will the renaming of the package also be included in this ticket? |
Contributor
Author
Will push a new PR once this is merged as it does have a lot of file changes |
Co-authored-by: Copilot <copilot@github.com>
markuczy
requested changes
May 25, 2026
| @@ -1,5 +1,13 @@ | |||
| import { setupZoneTestEnv } from 'jest-preset-angular/setup-env/zone' | |||
|
|
|||
| // JSDOM does not implement `innerText` which is used by Angular's testing utilities. This causes tests to fail with: | |||
Contributor
There was a problem hiding this comment.
"This causes tests to fail with: " -> is this unfinished?
| const oneCXLibVersion = '^7.7.2'; | ||
| const angularVersion = '^20.3.9'; | ||
| const oneCXLibVersion = '^8.2.2'; | ||
| const angularVersion = '21.2.9'; |
Contributor
There was a problem hiding this comment.
Suggested change
| const angularVersion = '21.2.9'; | |
| const angularVersion = '^21.2.9'; |
Contributor
There was a problem hiding this comment.
With new module federation:
- requiredVersion = package.json version
- providedVersion = package-lock.json version
Because of this, we should use ^21.0.0 for every generated app.
Comment on lines
+126
to
+130
| '@ngrx/component': '21.1.0', | ||
| '@ngrx/effects': '21.1.0', | ||
| '@ngrx/router-store': '21.1.0', | ||
| '@ngrx/store': '21.1.0', | ||
| '@ngrx/store-devtools': '21.1.0', |
Contributor
There was a problem hiding this comment.
Suggested change
| '@ngrx/component': '21.1.0', | |
| '@ngrx/effects': '21.1.0', | |
| '@ngrx/router-store': '21.1.0', | |
| '@ngrx/store': '21.1.0', | |
| '@ngrx/store-devtools': '21.1.0', | |
| '@ngrx/component': '^21.1.0', | |
| '@ngrx/effects': '^21.1.0', | |
| '@ngrx/router-store': '^21.1.0', | |
| '@ngrx/store': '^21.1.0', | |
| '@ngrx/store-devtools': '^21.1.0', |
| '@ngrx/store-devtools': '21.1.0', | ||
| '@webcomponents/webcomponentsjs': '^2.8.0', | ||
| 'zone.js': '~0.15.0', | ||
| 'zone.js': '0.16.1', |
Contributor
There was a problem hiding this comment.
Suggested change
| 'zone.js': '0.16.1', | |
| 'zone.js': '~0.16.1', |
| '@angular/platform-browser-dynamic': angularVersion, | ||
| '@angular/router': angularVersion, | ||
| primeflex: '^3.3.1', | ||
| primeflex: '^4.0.0', |
Contributor
There was a problem hiding this comment.
Do we need to update primeflex to avoid dependency issues? If not I would not do that since we should move to tailwind anyways.
Comment on lines
+170
to
+175
| 'angular-eslint': '21.3.1', | ||
| '@angular-eslint/builder': '21.3.1', | ||
| '@angular-eslint/eslint-plugin': '21.3.1', | ||
| '@angular-eslint/eslint-plugin-template': '21.3.1', | ||
| '@angular-eslint/schematics': '21.3.1', | ||
| '@angular-eslint/template-parser': '21.3.1', |
Contributor
There was a problem hiding this comment.
Suggested change
| 'angular-eslint': '21.3.1', | |
| '@angular-eslint/builder': '21.3.1', | |
| '@angular-eslint/eslint-plugin': '21.3.1', | |
| '@angular-eslint/eslint-plugin-template': '21.3.1', | |
| '@angular-eslint/schematics': '21.3.1', | |
| '@angular-eslint/template-parser': '21.3.1', | |
| 'angular-eslint': '^21.3.1', | |
| '@angular-eslint/builder': '^21.3.1', | |
| '@angular-eslint/eslint-plugin': '^21.3.1', | |
| '@angular-eslint/eslint-plugin-template': '^21.3.1', | |
| '@angular-eslint/schematics': '^21.3.1', | |
| '@angular-eslint/template-parser': '^21.3.1', |
| jest: '^30.0.0', | ||
| 'jest-environment-jsdom': '^30.0.0', | ||
| 'jest-preset-angular': '^16.0.0', | ||
| 'jest-preset-angular': '16.1.4', |
Contributor
There was a problem hiding this comment.
Suggested change
| 'jest-preset-angular': '16.1.4', | |
| 'jest-preset-angular': '^16.1.4', |
Comment on lines
+74
to
+78
| '@ngrx/effects': '21.1.0', | ||
| '@ngrx/router-store': '21.1.0', | ||
| '@ngrx/store': '21.1.0', | ||
| '@ngrx/component': '21.1.0', | ||
| '@ngrx/store-devtools': '21.1.0', |
Contributor
There was a problem hiding this comment.
Suggested change
| '@ngrx/effects': '21.1.0', | |
| '@ngrx/router-store': '21.1.0', | |
| '@ngrx/store': '21.1.0', | |
| '@ngrx/component': '21.1.0', | |
| '@ngrx/store-devtools': '21.1.0', | |
| '@ngrx/effects': '^21.1.0', | |
| '@ngrx/router-store': '^21.1.0', | |
| '@ngrx/store': '^21.1.0', | |
| '@ngrx/component': '^21.1.0', | |
| '@ngrx/store-devtools': '^21.1.0', |
| readonly locale = inject(LOCALE_ID); | ||
|
|
||
| calendars = viewChildren(DatePicker) | ||
| // TODO: use signal after updating libs and pass appropriate value accordingly in buildSearchCriteria. |
Contributor
There was a problem hiding this comment.
we should use the new utility here
Contributor
Author
|
Added to draft for now
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.