feat: Navigation architecture - flat sidebar model with dynamic phase sub-items#726
Open
feat: Navigation architecture - flat sidebar model with dynamic phase sub-items#726
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
… sub-items - Flatten navigationConfig.ts with discriminated union SidebarItem type - Add SectionId/StepId types and phaseToSectionId helpers - Rewrite useProcessNavigation for flat section model with dynamic phases - Add useProcessPhases hook to fetch phases for navigation - Add usePhaseValidation hook for per-phase validation state - Update shared validation utilities in processBuilderValidation.ts
… guard - Move all translation keys from stepper-navigation to PR 1 so downstream branches typecheck cleanly without needing type assertions - Fix ProcessBuilderSectionNav to use isDynamic narrowing instead of t() on dynamic phase items (which have string labelKeys, not TranslationKeys)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
navigationConfig.tswith discriminated unionSidebarItemtype,SectionId/StepIdtypes, andphaseToSectionIdhelpersuseProcessNavigationfor flat section model with dynamic phase sub-itemsuseProcessPhaseshook to fetch phases for navigationusePhaseValidationhook for per-phase validation stateprocessBuilderValidation.tsPure logic layer — no visual changes. Reviewers can validate the data model independently of any UI changes.
Stack
This is PR 1 of 3 in the Process Builder sidebar refactor:
sidebar-components)process-builder-integration)Test plan
pnpm w:app typecheckuseProcessNavigationreturns correct flat sections including dynamic phase sub-itemsusePhaseValidationreturns correct validation state per phase